Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.15.z] fixed api audit tests #13376

Merged
merged 1 commit into from
Dec 12, 2023
Merged

[6.15.z] fixed api audit tests #13376

merged 1 commit into from
Dec 12, 2023

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #13368

Problem Statement

#12989 swapped entities for target_sat.api, but:

ent = entities.Architecture()
ent.__class__.__name__.lower()
'architecture'

ent_new = target_sat.api.Architecture()
ent_new.__class__.__name__.lower()
'decclass'

Hence test failures

Solution

made the search type explicit, not too happy about test not reusing the same data but went for the fast solution with component evaluation in sight for this one

@pondrejk @web-flow
fixed api audit tests
97da4ec 
(cherry picked from commit 2809bdb)
@Satellite-QE Satellite-QE requested a review from a team as a code owner December 11, 2023 19:12
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Dec 11, 2023
@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Dec 11, 2023
@omkarkhatavkar
Copy link

trigger: test-robottelo
pytest: tests/foreman/api/test_audit.py

@Gauravtalreja1 Gauravtalreja1 merged commit 486720d into 6.15.z Dec 12, 2023
13 of 14 checks passed
@Gauravtalreja1 Gauravtalreja1 deleted the cherry-pick-6.15.z-2809bdb4018fc00974b1144f53d4fdd416e74eb3 branch December 12, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

Assignees

@pondrejk pondrejk

Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Satellite-QE @omkarkhatavkar @Gauravtalreja1 @pondrejk